Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

krew: init at 0.4.0 #104910

Merged
merged 1 commit into from Dec 9, 2020
Merged

krew: init at 0.4.0 #104910

merged 1 commit into from Dec 9, 2020

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Nov 25, 2020

Motivation for this change

krew is the package manager for kubectl plugins.

Signed-off-by: Vincent Demeester vincent@sbr.pm

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

pkgs/development/tools/krew/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/krew/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/krew/default.nix Outdated Show resolved Hide resolved
@@ -11540,6 +11540,7 @@ in
kind = callPackage ../development/tools/kind { };

khronos-ocl-icd-loader = callPackage ../development/libraries/khronos-ocl-icd-loader { };
krew = callPackage ../development/tools/krew { };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
krew = callPackage ../development/tools/krew { };
krew = callPackage ../development/tools/krew { };

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see what this diff is about 😅

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a space at the end which fails the editor check.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104910 run on x86_64-linux 1

1 package built:
  • krew

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104910 run on x86_64-darwin 1

1 package built:
  • krew

@vdemeester
Copy link
Member Author

@SuperSandro2000 updated 😉

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104910 run on x86_64-darwin 1

1 package built:
  • krew

`krew` is the package manager for kubectl plugins.

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104910 run on x86_64-darwin 1

1 package built:
  • krew

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104910 run on x86_64-linux 1

1 package built:
  • krew

@SuperSandro2000 SuperSandro2000 merged commit d275ac8 into NixOS:master Dec 9, 2020
@vdemeester vdemeester deleted the add-krew branch December 9, 2020 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants