Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p7zip: 17.01 -> 17.03 #104912

Merged
merged 1 commit into from Jan 14, 2021
Merged

p7zip: 17.01 -> 17.03 #104912

merged 1 commit into from Jan 14, 2021

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Nov 25, 2020

Motivation for this change

Upstream release.

Patch is needed to fix compilation, see p7zip-project/p7zip#52

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from 7c6f434c November 25, 2020 17:13
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104912 run on x86_64-darwin 1

14 packages marked as broken and skipped:
  • dtrx
  • far2l
  • multibootusb
  • patool
  • portmod
  • python27Packages.binwalk
  • python27Packages.binwalk-full
  • python27Packages.patool
  • python37Packages.binwalk
  • python37Packages.binwalk-full
  • python37Packages.patool
  • python38Packages.binwalk
  • python38Packages.binwalk-full
  • python38Packages.patool
4 packages built:
  • hostsblock
  • kcc
  • p7zip
  • rarcrack

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104912 run on x86_64-linux 1

3 packages marked as broken and skipped:
  • linuxPackages_hardkernel_4_14.prl-tools
  • linuxPackages_hardkernel_latest.prl-tools
  • python27Packages.binwalk-full
8 packages failed to build:
  • linuxPackages_4_14.prl-tools
  • linuxPackages_4_4.prl-tools
  • linuxPackages_4_9.prl-tools
  • patool (python38Packages.patool)
  • portmod
  • python27Packages.patool
  • python37Packages.patool
  • sabnzbd
48 packages built:
  • dtrx
  • far2l
  • fuse-7z-ng
  • hostsblock
  • kcc
  • libsForQt5.ark (kdeApplications.ark ,libsForQt515.ark)
  • libsForQt512.ark
  • libsForQt514.ark
  • lightburn
  • linuxPackages-libre.ply
  • linuxPackages.ply (linuxPackages_5_4.ply ,linuxPackages_hardened.ply ,linuxPackages_xen_dom0.ply ,linuxPackages_xen_dom0_hardened.ply)
  • linuxPackages_4_14.ply
  • linuxPackages_4_19.ply
  • linuxPackages_4_4.ply
  • linuxPackages_4_9.ply
  • linuxPackages_5_8.ply
  • linuxPackages_5_9.ply (linuxPackages_latest.ply ,linuxPackages_latest_hardened.ply ,linuxPackages_latest_xen_dom0.ply ,linuxPackages_latest_xen_dom0_hardened.ply)
  • linuxPackages_hardkernel_4_14.ply (linuxPackages_hardkernel_latest.ply)
  • linuxPackages_latest-libre.ply
  • linuxPackages_testing_bcachefs.ply
  • linuxPackages_zen.ply
  • lutris
  • lutris-free
  • lutris-unwrapped
  • multibootusb
  • p7zip
  • playonlinux
  • protontricks
  • python27Packages.binwalk
  • python37Packages.binwalk
  • python37Packages.binwalk-full
  • python38Packages.binwalk
  • python38Packages.binwalk-full
  • rarcrack
  • spring
  • springLobby
  • sweethome3d.application
  • sweethome3d.furniture-editor
  • sweethome3d.textures-editor
  • tdm
  • unetbootin
  • win-qemu
  • win-signed-gplpv-drivers
  • win-spice
  • win-virtio
  • winetricks
  • woeusb
  • zdoom

Some of the failures are time outs.

patool:

patool: Listing /build/source/tests/data/t.txt.xz.foo ...
patool: running /nix/store/yvnjdd2m2323vdrmf6hyhzvf37ir36hz-p7zip-17.02/bin/7z l -y -- /build/source/tests/data/t.txt.xz.foo

7-Zip [64] 17.02 : Copyright (c) 1999-2020 Igor Pavlov : 2017-08-28
p7zip Version 17.02 (locale=C.UTF-8,Utf16=on,HugeFiles=on,64 bits,8 CPUs x64)

Scanning the drive for archives:
1 file, 60 bytes (1 KiB)

Listing archive: /build/source/tests/data/t.txt.xz.foo

--
Path = /build/source/tests/data/t.txt.xz.foo
Type = xz
Physical Size = 60
Method = LZMA2:23 CRC64
Streams = 1
Blocks = 1

   Date      Time    Attr         Size   Compressed  Name
------------------- ----- ------------ ------------  ------------------------
                    .....            2           60  t.txt.xz
------------------- ----- ------------ ------------  ------------------------
                                     2           60  1 files
----------------------------- Captured stderr call -----------------------------
/nix/store/yvnjdd2m2323vdrmf6hyhzvf37ir36hz-p7zip-17.02/bin/7z: line 2:   690 Segmentation fault      (core dumped) "/nix/store/yvnjdd2m2323vdrmf6hyhzvf37ir36hz-p7zip-17.02/lib/p7zip/7z" "$@"
=========================== short test summary info ============================
FAILED tests/archives/test_7z.py::Test7z::test_7z - patoolib.util.PatoolError...
FAILED tests/archives/test_7z.py::Test7z::test_7z_file - patoolib.util.Patool...
[0mm=========== 2 failed, 72 passed, 96 skipped, 4 deselected in 10.01s ===========

@ajs124 ajs124 marked this pull request as draft November 26, 2020 02:07
@ajs124 ajs124 changed the title p7zip: 17.01 -> 17.02 p7zip: 17.01 -> 17.03 Jan 14, 2021
@ajs124 ajs124 marked this pull request as ready for review January 14, 2021 01:59
@ajs124 ajs124 requested a review from luc65r January 14, 2021 02:01
@7c6f434c 7c6f434c merged commit f62ab91 into NixOS:master Jan 14, 2021
@7c6f434c
Copy link
Member

patool / portmod work now, so hopefully 17.03 has the crash fixed…

@ajs124 ajs124 deleted the upd/p7zip branch January 14, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@luc65r luc65r Awaiting requested review from luc65r

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ajs124 @SuperSandro2000 @7c6f434c