elmPackages.elm-review: Init at 2.3.3 #105371
Conversation
| "elm-xref", | ||
| "create-elm-app", | ||
| "elm-optimize-level-2" | ||
| "elm-analyse", |
There was a problem hiding this comment.
now follows .editorconfig rules
ofborg
bot
added
8.has: package (new)
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
labels
|
@GrahamcOfBorg build elmPackages |
| nodeEnv = import ../../../node-packages/node-env.nix { | ||
| inherit (pkgs) stdenv python2 util-linux runCommand writeTextFile; | ||
| nodeEnv = import ./node-env.nix { | ||
| inherit (pkgs) stdenv python2 utillinux runCommand writeTextFile; |
There was a problem hiding this comment.
| inherit (pkgs) stdenv python2 utillinux runCommand writeTextFile; | |
| inherit (pkgs) stdenv python2 util-linux runCommand writeTextFile; |
There was a problem hiding this comment.
This file is generated by node2nix. I think this change comes from the new version. If we would revert this, we should also ditch node-env.nix I think.
There was a problem hiding this comment.
@domenkozar what do you think about this? Should I edit generated files?
There was a problem hiding this comment.
I'd keep it as generated and we can fix node2nix to do the right thing.
There was a problem hiding this comment.
so in this PR I did not change any of generated file, just regenerated them. This suggestion is to change a file which was generated. This change in how node2nix generates file is also why we now need our own node-env.nix. I'm not sure if anything needs fixing because the newly generated files do work just fine. I think all we would need to avoid creating node-env.nix would be to regenerate nodePackages as well which I don't want to do to keep scope of this change small.
Furthermore I think it'll be better for node2nix maintainers if we would break the dependecy on their node-env.nix for a moment so they can do the transition to new format on their own terms without breaking elmPackages.
|
Result of 5 packages built:
|
There was a problem hiding this comment.
Looks good to me, but I'll let @domenkozar do the review and merge.
|
I'll also open separate PR for marking aarch as bad platform for things that are failing there once this is merged. |
Elm-review is the most advanced linter for elm language. I think we might want to use it for nixos-search.
I had to temporarily generate node-env.nix file for elmPackages as we're waiting for nodePackages to get updated.
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)