Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slurm/nixos: 20.02.5.1 -> 20.11.0.1, fix module #105369

Merged
merged 2 commits into from Dec 16, 2020
Merged

slurm/nixos: 20.02.5.1 -> 20.11.0.1, fix module #105369

merged 2 commits into from Dec 16, 2020

Conversation

markuskowa
Copy link
Member

Motivation for this change

Since slurm-20.11.0.1 the dbd server requires slurmdbd.conf to be in mode 600 to protect the database password. This change creates slurmdbd.conf on-the-fly at service startup and thus avoids that the database password ends up in the nix store and improves security.

Things done
  • updated slurm package
  • fixed config options for dbdserver
  • updated release notes
  • update slurm test
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from jagajaga November 29, 2020 15:17
@markuskowa markuskowa force-pushed the upd-slurm branch 2 times, most recently from fc1ab67 to 1e3a281 Compare December 5, 2020 18:38
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/399

@markuskowa
Copy link
Member Author

markuskowa commented Dec 14, 2020 •
edited

@GrahamcOfBorg eval

@markuskowa markuskowa force-pushed the upd-slurm branch 2 times, most recently from 24c3ba9 to 2455c48 Compare December 14, 2020 22:39
symphorien
symphorien approved these changes Dec 15, 2020
View reviewed changes
Copy link
Member

@symphorien symphorien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the diff looks good to me, I didn't test compilation/running.

@markuskowa
slurm: 20.02.6.1 -> 20.11.0.1
f074e87
@markuskowa
nixos/slurm: fix dbdserver config file handling
5df0cf7 
Since slurm-20.11.0.1 the dbd server requires slurmdbd.conf to be
in mode 600 to protect the database password. This change creates
slurmdbd.conf on-the-fly at service startup and thus avoids that
the database password ends up in the nix store.
@markuskowa markuskowa merged commit e25f527 into NixOS:master Dec 16, 2020
@markuskowa markuskowa deleted the upd-slurm branch December 16, 2020 20:02
@markuskowa
Copy link
Member Author

@symphorien thanks for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@symphorien symphorien symphorien approved these changes

@veprbl veprbl Awaiting requested review from veprbl

@lsix lsix Awaiting requested review from lsix

@ikervagyok ikervagyok Awaiting requested review from ikervagyok

@jagajaga jagajaga Awaiting requested review from jagajaga

Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: documentation 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@markuskowa @nixos-discourse @symphorien