New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
slurm/nixos: 20.02.5.1 -> 20.11.0.1, fix module #105369
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markuskowa
force-pushed
the
upd-slurm
branch
2 times, most recently
from
December 5, 2020 18:38
fc1ab67
to
1e3a281
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
symphorien
reviewed
Dec 11, 2020
markuskowa
force-pushed
the
upd-slurm
branch
from
December 14, 2020 21:08
1e3a281
to
1eb99fc
Compare
@GrahamcOfBorg eval |
symphorien
reviewed
Dec 14, 2020
markuskowa
force-pushed
the
upd-slurm
branch
2 times, most recently
from
December 14, 2020 22:39
24c3ba9
to
2455c48
Compare
symphorien
approved these changes
Dec 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the diff looks good to me, I didn't test compilation/running.
Since slurm-20.11.0.1 the dbd server requires slurmdbd.conf to be in mode 600 to protect the database password. This change creates slurmdbd.conf on-the-fly at service startup and thus avoids that the database password ends up in the nix store.
markuskowa
force-pushed
the
upd-slurm
branch
from
December 16, 2020 19:35
2455c48
to
5df0cf7
Compare
@symphorien thanks for the feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Since slurm-20.11.0.1 the dbd server requires slurmdbd.conf to be in mode 600 to protect the database password. This change creates slurmdbd.conf on-the-fly at service startup and thus avoids that the database password ends up in the nix store and improves security.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)