nixos/wooting: add xinput support #105370
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonringer
reviewed
May 19, 2021
| udev rules that give NixOS permission to communicate with Wooting keyboards in xinput mode | ||
| ''; | ||
| platforms = platforms.linux; | ||
| license = "unknown"; |
There was a problem hiding this comment.
if there's no license, I think we have to assume that it's unfree.
Comment on lines
+7
to
+8
| # Source: https://wooting.helpscoutdocs.com/article/83-guide-configuring-xinput-support-for-the-wootings-under-linux | ||
| src = [ ./wooting-xinput.rules ]; |
There was a problem hiding this comment.
If you already vendored the text, you could probably use a trivial builder like writeTextFile
There was a problem hiding this comment.
I've left the rules in a separate file for now, and have added some new rules that were added (for new keyboard models) since this PR was made.
This commit adds xinput support for Wooting keyboards to the `hardware.wooting` NixOS module, enabled by setting the `hardware.wooting.xinput.enable` option. Signed-off-by: David Wood <david@davidtw.co>
|
I too think there's no need (at least in the meantime) to create a package just for the udev rules. And it'd be better to add them to the service directly. Also, there's a CI error now. |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This PR adds xinput support for Wooting keyboards to the
hardware.wootingNixOS module, enabled by setting thehardware.wooting.xinput.enableoption, see upstream documentation.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)