Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.hidapi: Fix compilation on darwin #104565

Merged
merged 1 commit into from Nov 23, 2020
Merged

pythonPackages.hidapi: Fix compilation on darwin #104565

merged 1 commit into from Nov 23, 2020

Conversation

SuperSandro2000
Copy link
Member

Motivation for this change

#104506

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 6.topic: python labels Nov 22, 2020
@ofborg ofborg bot requested review from np and prusnak November 22, 2020 06:26
prusnak
prusnak approved these changes Nov 22, 2020
View reviewed changes
Copy link
Member

@prusnak prusnak left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I am the upstream of python-hidapi and we indeed added AppKit dependency to macOS build in 0.10.0.post1

@SuperSandro2000
Copy link
Member Author

Result of nixpkgs-review pr 104565 run on x86_64-linux 1

@ofborg ofborg bot requested a review from prusnak November 22, 2020 17:25
@prusnak prusnak merged commit b2885cb into NixOS:master Nov 23, 2020
@SuperSandro2000 SuperSandro2000 deleted the hidapi-darwin branch August 26, 2021 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@np np Awaiting requested review from np

@prusnak prusnak Awaiting requested review from prusnak

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SuperSandro2000 @prusnak