New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runc: add wrapper for systemd #104545
runc: add wrapper for systemd #104545
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sorry, I don't understand what this PR is supposed to fix. Why does it need systemd in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only occurence to systemctl
seems to be in libcontainer/cgroups/systemd/user.go
, which should better be taken from /run/current-system/systemd/bin
instead of ${pkgs.systemd}/bin
, for the same reasons as #88492.
How does that work on non-nixos? |
I meant to wrap the binary to add this path to But first, what is your PR trying to fix? Looking back at |
|
Can you also add |
for cgroupsv2 it needs `busctl` and `systemctl` in its PATH.
Fixes cgroupsv2 + rootless + runc but
nixosTests.podman
still fails for some reason.Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)cc @flokli