Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "haskellPackages.trifecta: dontCheck on darwin" #104535

Merged
merged 1 commit into from Nov 22, 2020
Merged

Revert "haskellPackages.trifecta: dontCheck on darwin" #104535

merged 1 commit into from Nov 22, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Nov 21, 2020

This reverts commit 10e961c.

Fixed by 473b341.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Nov 21, 2020
@zowoq zowoq mentioned this pull request Nov 21, 2020
Closed
@cdepillabout
Copy link
Member

@GrahamcOfBorg build haskellPackages.trifecta

@cdepillabout
Copy link
Member

Hmm, the ofborg darwin job does not seem to be starting :-\

@zowoq I trust that you actually built this on Darwin, so I'll go ahead and merge it in. Thanks for updating this!

@cdepillabout cdepillabout merged commit 4fea8c8 into NixOS:haskell-updates Nov 22, 2020
@zowoq
Copy link
Contributor Author

zowoq commented Nov 22, 2020

ofborg darwin job does not seem to be starting

ofborg is still queuing jobs for darwin but the builder been offline for a couple of months.

@zowoq zowoq deleted the trifecta branch November 22, 2020 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: haskell 10.rebuild-darwin: 11-100 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zowoq @cdepillabout