stage-1: Use evdev bindings for recovery key #243
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you look at the changes, this was previously shelling out to a wrapper that, itself, was shelling-out to
evtest
to query the key states.That was done as an extremely MVP way to check for specific keys.
This is now done through FFI bindings. They're not "good" bindings, but they are proper enough, and more importantly, done through the same exact previous abstraction.
What do I mean by "good" bindings? It'd need to have a fancy object oriented API rather than just being a direct use of the FFI bindings. Though, using FFI bindings sure is fine enough.