Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

krusader: added qtbase in mkDerivation #103094

Closed
wants to merge 1 commit into from
Closed

krusader: added qtbase in mkDerivation #103094

wants to merge 1 commit into from

Conversation

flozy
Copy link

@flozy flozy commented Nov 7, 2020

Motivation for this change: #103033
Error description is here: https://nixos.wiki/wiki/Qt Paragraph: qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
#65399

Error: #103033
Error description is here: https://nixos.wiki/wiki/Qt   Paragraph: qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
#65399
@freezeboy
Copy link
Contributor

Could you please rename the commit and PR with the package name as a prefix please

@SuperSandro2000
Copy link
Member

Shouldn't this be used anywhere?

@flozy flozy changed the title Added qtbase in mkDerivation krusader: Added qtbase in mkDerivation Nov 7, 2020
@flozy flozy changed the title krusader: Added qtbase in mkDerivation krusader: added qtbase in mkDerivation Nov 7, 2020
@doronbehar
Copy link
Contributor

Could you please rename the commit and PR with the package name as a prefix please

@flozy the request is to do this for most importantly the commit message as well.

@flozy
Copy link
Author

flozy commented Nov 10, 2020

@doronbehar
@freezeboy
I would like to. Unfortunately I can't find a function to change that.

@freezeboy
Copy link
Contributor

You need to use git commit - - amend on your local repository and then push - f to force the change of the commit

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To comply with CONTRIBUTING.md please have the commit message name be of the format

<pkg-name>: <subject-line>

for more examples, please look at https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes

in your case, the commit message should be:

krusader: add qtbase

this can be done with:

git commit --amend
# edit subject line
git push ... ... --force

@jonringer
Copy link
Contributor

@flozy thanks for opening your first PR to nixpkgs :)

@SuperSandro2000
Copy link
Member

@flozy friendly ping

@flozy flozy closed this Nov 26, 2020
@flozy flozy deleted the patch-1 branch November 26, 2020 22:30
@flozy flozy mentioned this pull request Nov 26, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants