-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
krusader: added qtbase in mkDerivation #103094
Conversation
Error: #103033 Error description is here: https://nixos.wiki/wiki/Qt Paragraph: qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in "" #65399
Could you please rename the commit and PR with the package name as a prefix please |
Shouldn't this be used anywhere? |
@flozy the request is to do this for most importantly the commit message as well. |
@doronbehar |
You need to use git commit - - amend on your local repository and then push - f to force the change of the commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To comply with CONTRIBUTING.md please have the commit message name be of the format
<pkg-name>: <subject-line>
for more examples, please look at https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes
in your case, the commit message should be:
krusader: add qtbase
this can be done with:
git commit --amend
# edit subject line
git push ... ... --force
@flozy thanks for opening your first PR to nixpkgs :) |
@flozy friendly ping |
Motivation for this change: #103033
Error description is here: https://nixos.wiki/wiki/Qt Paragraph: qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
#65399