Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mutt: 1.14.7 -> 2.0.0 #103101

Merged
merged 2 commits into from Nov 8, 2020
Merged

mutt: 1.14.7 -> 2.0.0 #103101

merged 2 commits into from Nov 8, 2020

Conversation

matthiasbeyer
Copy link
Contributor

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthiasbeyer
mutt: 1.14.7 -> 2.0.0
e9e003e 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@SuperSandro2000
Copy link
Member

Does this update require a changelog entry?

@matthiasbeyer
Copy link
Contributor Author

I would say so, as mutt had some breaking changes (thus the major version update).

@danieldk
Copy link
Contributor

danieldk commented Nov 8, 2020

Yes, I think adding this to the release notes would be a good idea, with a link to

http://www.mutt.org/relnotes/2.0/

Could you add a separate commit to this PR that adds an item to the release notes?

@matthiasbeyer
Copy link
Contributor Author

I could, but the release notes are still ugly XML. I can apply a patch if you have one, though.

@danieldk
Copy link
Contributor

danieldk commented Nov 8, 2020

I could, but the release notes are still ugly XML. I can apply a patch if you have one, though.

I added a commit that adds an item to the release notes. Does that look ok to you?

@matthiasbeyer
Copy link
Contributor Author

Nice, thanks.

@ofborg ofborg bot requested a review from rnhmjoj November 8, 2020 16:39
danieldk
danieldk approved these changes Nov 8, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 103101 1

2 packages built:
  • grepm
  • mutt (mutt-with-sidebar)

Looks good to go then! Will merge when ofborg is also happy.

@danieldk danieldk merged commit d43f378 into NixOS:master Nov 8, 2020
@matthiasbeyer matthiasbeyer deleted the update-mutt branch November 8, 2020 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

@rnhmjoj rnhmjoj Awaiting requested review from rnhmjoj

Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: documentation 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matthiasbeyer @SuperSandro2000 @danieldk