Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix-prefetch-github: 4.0 -> 4.0.1 #103099

Merged

Conversation

seppeljordan
Copy link
Contributor

@seppeljordan seppeljordan commented Nov 7, 2020

Motivation for this change

A new version is available upstream that fixes an incompatibility with newer nix versions.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@seppeljordan
Copy link
Contributor Author

Result of nixpkgs-review pr 103099 1

3 packages built:
  • nix-prefetch-github (python38Packages.nix-prefetch-github)
  • pypi2nix
  • python37Packages.nix-prefetch-github


src = fetchPypi {
inherit pname version;
sha256 = "sha256-STUyMUCWAHfDA6dkpiOqSRBL3/tubedUbWa94Kp/764=";
sha256 = "sha256-asfRohjOgYxMV/wprKvxUD328GVJQkAYnuAkE09kKgs=";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sha256 = "sha256-asfRohjOgYxMV/wprKvxUD328GVJQkAYnuAkE09kKgs=";
sha256 = "asfRohjOgYxMV/wprKvxUD328GVJQkAYnuAkE09kKgs=";

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the advantage of this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should sha256 be there twice?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should sha256 not be there twice?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like you are trolling me. Don't appreciate that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SuperSandro2000 Can you tell me what your problem is? I asked you the simple question what the advantage of your change is. I asked because it is not clear to me. You answered my question with another question which does not make any sense to me. And after expressing that I feel disrespected by you I get a thumbs down. Now I feel stupid and disrespected.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seppeljordan I believe that @SuperSandro2000's question was rhetorical, they are saying that repeating "sha256" is unnecessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@expipiplus1 Understood. And don't get me wrong, I can put this in the PR no problem, but...

You see I was asking since the program in question does calculate checksums for github repositories intended to be used with nix. And currently it outputs hashes in the same formatting as the one in question in this PR. If the redundant 'sha256-' is the main problem then I don't really care too much. Should it be a standard for this repo that "we don't put sha256- in front of our hashes" then I would very much care. There could be other issues with this format that I wouldn't know about, e.g. compatibility issues with external tools.

I am not expecting an answer, but should you know about any of this it would be awesome if you would tell me.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it's a standard, but sha256 = "sha256- only appears 199 times in the whole of nixpkgs, so it seems to be a more or less de-facto standard. Perhaps this should be taken up against the nix-prefetch-github repo.

In terms of compatibility I don't know off the top of my head if any other tools will break, but other tools (like update-nix-fetchgit, and the version of nix-prefetch-github in the current nixpkgs HEAD do not output the sha256- prefix.

@seppeljordan seppeljordan force-pushed the update-nix-prefetch-github-4.0.1 branch from 6e55ce9 to cc0f63c Compare November 8, 2020 17:58
@seppeljordan
Copy link
Contributor Author

Result of nixpkgs-review pr 103099 1

3 packages built:
  • nix-prefetch-github (python38Packages.nix-prefetch-github)
  • pypi2nix
  • python37Packages.nix-prefetch-github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants