Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scheherazade-new: init at 3.000 #103117

Merged
merged 1 commit into from Nov 15, 2020
Merged

scheherazade-new: init at 3.000 #103117

merged 1 commit into from Nov 15, 2020

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Nov 8, 2020

Motivation for this change

Major update: https://software.sil.org/scheherazade/release-3-000/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lukegb
Copy link
Contributor

lukegb commented Nov 8, 2020

Hmm. I suspect that given that this font has entirely new metrics and a new name, you might be better off packaging this separately as a new package - from the homepage:

Why the name change? Why is this now called Scheherazade New?

Scheherazade has been around for many years. Over the years people have complained about the small size of the font in comparison to other fonts. We have completely resized the glyphs in Scheherazade New. If we had kept the same name, the layout of all existing documents would be affected. Thus, this name change allows users to keep using Scheherazade for older documents, but they can begin using Scheherazade New for new documents."

What do you think?

@vbgl vbgl changed the title scheherazade: 2.100 → 3.000 scheherazade: init at 3.000 Nov 8, 2020
@vbgl vbgl changed the title scheherazade: init at 3.000 scheherazade-new: init at 3.000 Nov 8, 2020
@vbgl
Copy link
Contributor Author

vbgl commented Nov 8, 2020

All right, let’s keep the old one and package the new one as scheherazade-new.

@vbgl vbgl merged commit b94a294 into NixOS:master Nov 15, 2020
@vbgl vbgl deleted the scheherazade-3.000 branch November 15, 2020 08:33
@vbgl
Copy link
Contributor Author

vbgl commented Nov 15, 2020

Merged into 20.09 as 879bc29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vbgl @lukegb