Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnomeExtensions.night-theme-switcher: 36 -> 40 #103097

Merged
merged 1 commit into from Jan 18, 2021
Merged

gnomeExtensions.night-theme-switcher: 36 -> 40 #103097

merged 1 commit into from Jan 18, 2021

Conversation

jonafato
Copy link
Contributor

@jonafato jonafato commented Nov 7, 2020

Motivation for this change

Night Theme Switcher has a new release with bug fixes and new features,
most notably GNOME Shell 3.38 support.

Full changelog

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonafato
gnomeExtensions.night-theme-switcher: 36 -> 40
a259abc 
Night Theme Switcher has a new release with bug fixes and new features,
most notably GNOME Shell 3.38 support.

[Full changelog](https://gitlab.com/rmnvgr/nightthemeswitcher-gnome-shell-extension/-/compare/v36...v40)
@jonafato
Copy link
Contributor Author

@NixOS/gnome Now that 3.38 is on master, can I get a review on this update? The extension works even with the older version, but the bump here explicitly declares 3.38 support.

@jtojnar
Copy link
Contributor

jtojnar commented Nov 13, 2020

Looking at the changelog, I see that it added dependency on Geoclue typelib. Is that inherited from GNOME Shell? Even in preferences? Otherwise looks good.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 103097 run on x86_64-linux 1

1 package built:
  • gnomeExtensions.night-theme-switcher

@SuperSandro2000 SuperSandro2000 merged commit 87cdded into NixOS:master Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonafato @jtojnar @SuperSandro2000