Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clj-kondo: 2020.04.05 -> 2020.11.07 #103096

Merged
merged 1 commit into from Nov 8, 2020
Merged

clj-kondo: 2020.04.05 -> 2020.11.07 #103096

merged 1 commit into from Nov 8, 2020

Conversation

bennyandresen
Copy link
Contributor

Motivation for this change

update to latest version that includes a jar that works with graalvm11.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin label Nov 7, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Nov 7, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@ofborg ofborg bot requested a review from jlesquembre November 7, 2020 19:06
@thiagokokada
Copy link
Contributor

Result of nixpkgs-review pr 103096 1

1 package built:
  • clj-kondo

thiagokokada
thiagokokada approved these changes Nov 7, 2020
View reviewed changes
Copy link
Contributor

@thiagokokada thiagokokada left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine, tested with https://github.com/http-kit/http-kit repository 👍 .

/status needs_merger

@marvin-mk2 marvin-mk2 bot requested a review from kevincox November 7, 2020 23:18
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 103096 run on x86_64-linux 1

1 package built:
  • clj-kondo

@kevincox kevincox merged commit c2a3de5 into NixOS:master Nov 8, 2020
@bennyandresen bennyandresen deleted the clj-kondo_upgrade branch November 11, 2020 21:29
This was referenced Nov 12, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagokokada thiagokokada thiagokokada approved these changes

@jlesquembre jlesquembre Awaiting requested review from jlesquembre

@kevincox kevincox Awaiting requested review from kevincox

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 awaiting_merger marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bennyandresen @thiagokokada @SuperSandro2000 @kevincox