Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dogdns: init at 0.1.0 #103115

Merged
merged 1 commit into from Nov 8, 2020
Merged

dogdns: init at 0.1.0 #103115

merged 1 commit into from Nov 8, 2020

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Nov 8, 2020

Motivation for this change
Things done

The tool is actually named "dog" but since we already have a package with the same name I renamed it to "dogdns". I wonder if "dogcli" or something would be better.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice program, didn't know this

Result of nixpkgs-review pr 103115 1

1 package built:
  • dogdns

Confirmed to work on Linux. This probably needs additional dependencies for Darwin (as usual :(), maybe you could add them based on Hydra output later.

@danieldk
Copy link
Contributor

danieldk commented Nov 8, 2020

BTW, I like your proposed attribute name more than dogcli.

@danieldk danieldk merged commit 72c424a into NixOS:master Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants