Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

erlangR23: 23.1 -> 23.1.2 #103111

Merged
merged 1 commit into from Nov 9, 2020
Merged

erlangR23: 23.1 -> 23.1.2 #103111

merged 1 commit into from Nov 9, 2020

Conversation

braunse
Copy link
Contributor

@braunse braunse commented Nov 8, 2020

Motivation for this change

Upstream release: https://github.com/erlang/otp/releases/tag/OTP-23.1.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Closure size impact
/nix/store/lgcvy9dknyg9jrarfc1jb5g0ny49l047-erlang-23.1.2         606425656
/nix/store/60cl373d5d5f741cvs7m2akj5hv1sdmq-erlang-23.1           616544448

Obsoletes #102135

@braunse
Copy link
Contributor Author

braunse commented Nov 8, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Nov 8, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@braunse braunse mentioned this pull request Nov 8, 2020
Closed
10 tasks
@braunse
Copy link
Contributor Author

braunse commented Nov 8, 2020 •
edited

On Debian x86_64:

Result of nixpkgs-review pr 103111 1

1 package built:
  • erlangR23

@braunse
Copy link
Contributor Author

braunse commented Nov 8, 2020 •
edited

On NixOS 20.09 x86_64:

Result of nixpkgs-review pr 103111 1

1 package built:
  • erlangR23

@alyssais alyssais merged commit c8e9728 into NixOS:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: erlang 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 marvin needs_reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@braunse @alyssais