Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inxi: add pciutils #103104

Merged
merged 1 commit into from Jan 9, 2021
Merged

inxi: add pciutils #103104

merged 1 commit into from Jan 9, 2021

Conversation

Artturin
Copy link
Member

@Artturin Artturin commented Nov 8, 2020

Motivation for this change

No pciutils

 inxi -G
Graphics:  Message: No Device data found.
           Display: wayland server: X.Org 1.20.8 driver: N/A resolution: 1: 2560x1440~144Hz 2: 1080x1920~60Hz
           3: 1920x1080~60Hz
           OpenGL: renderer: Radeon RX Vega (VEGA10 DRM 3.39.0 5.9.1 LLVM 9.0.1) v: 4.6 Mesa 20.1.9

With pciutils

inxi -G
Graphics:  Device-1: Intel Xeon E3-1200 v3/4th Gen Core Processor Integrated Graphics driver: i915 v: kernel
           Device-2: Advanced Micro Devices [AMD/ATI] Vega 10 XL/XT [Radeon RX Vega 56/64] driver: amdgpu v: kernel
           Display: wayland server: X.Org 1.20.8 driver: amdgpu note: display driver n/a resolution: 1: 2560x1440~144Hz
           2: 1080x1920~60Hz 3: 1920x1080~60Hz
           OpenGL: renderer: Radeon RX Vega (VEGA10 DRM 3.39.0 5.9.1 LLVM 9.0.1) v: 4.6 Mesa 20.1.9

i put pciutils in recommendedSystemPrograms instead of recommendedDisplayInformationPrograms because inxi -G can also be used in a tty to show devices

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"

Idk how to do this since pciutils is hidden under a option

  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Artturin Artturin changed the title add pciutils to inxi inxi: add pciutils Nov 8, 2020
@Artturin
Copy link
Member Author

Artturin commented Dec 10, 2020

i think i messed that up?
will try to fix later

@turboMaCk
Copy link
Member

cc @primeos who is listed as mantainer

Copy link
Member

@primeos primeos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! And also thanks for the ping @turboMaCk :)

@primeos primeos merged commit fa2b9b8 into NixOS:master Jan 9, 2021
@Artturin Artturin deleted the add-pciutils-inxi branch August 3, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants