Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate lexically dependent behavior of Past/Rose/Fell/... without explicit domain= argument #534

Closed
whitequark opened this issue Nov 7, 2020 · 1 comment
Closed

Deprecate lexically dependent behavior of Past/Rose/Fell/... without explicit domain= argument #534

whitequark opened this issue Nov 7, 2020 · 1 comment
Labels
improvement

Comments

@whitequark
Copy link
Member

While the exact details of how Past/Rose/Fell/... are still subject to discussion in #526, it seems clear that the current behavior, with the domain taken (when not specified) from the lexically enclosing m.d.<domain> += statement, was a mistake. Let's deprecate it in 0.3 to be able to change it in 0.4.
@whitequark whitequark added this to the 0.3 milestone Nov 7, 2020
@whitequark whitequark mentioned this issue Nov 7, 2020
Closed
@whitequark whitequark removed this from the 0.3 milestone Nov 8, 2020
@whitequark
Copy link
Member Author

@awygle raised some good objections to this plan, and I now think that this deprecation would be too rushed to go well in 0.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement
Milestone
No milestone
Development

No branches or pull requests
1 participant
@whitequark