Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.datasets: 1.0.1 -> 1.1.2 #103116

Merged
merged 1 commit into from Nov 14, 2020
Merged

python3Packages.datasets: 1.0.1 -> 1.1.2 #103116

merged 1 commit into from Nov 14, 2020

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Nov 8, 2020

Motivation for this change

Changelog:

https://github.com/huggingface/datasets/releases/tag/1.1.2
https://github.com/huggingface/datasets/releases/tag/1.1.0
https://github.com/huggingface/datasets/releases/tag/1.0.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alyssais
Copy link
Member

alyssais commented Nov 9, 2020

@GrahamcOfBorg build python3Packages.datasets

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 11, 2020 •
edited

Result of nixpkgs-review pr 103116 run on x86_64-darwin 1

2 packages failed to build:
  • python37Packages.datasets
  • python38Packages.datasets

Edit: Works when I build them manually....

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/366

@danieldk danieldk merged commit bd7c1f4 into NixOS:master Nov 14, 2020
@danieldk danieldk deleted the datasets-1.1.2 branch November 14, 2020 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@danieldk @alyssais @SuperSandro2000 @nixos-discourse