Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lollypop: 1.3.2 -> 1.4.5 #103105

Merged
merged 1 commit into from Nov 9, 2020
Merged

lollypop: 1.3.2 -> 1.4.5 #103105

merged 1 commit into from Nov 9, 2020

Conversation

jonafato
Copy link
Contributor

@jonafato jonafato commented Nov 8, 2020

Motivation for this change

lollypop has a new release.

Full changelog

This change depends on libhandy updates, so it targets staging-next.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Why did you target staging_next? There are not that many rebuilds.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 8, 2020 •
edited

on linux x86_64

Project name: lollypop
Project version: 1.4.5
Host machine cpu family: x86_64
Host machine cpu: x86_64

meson.build:5:0: ERROR: Could not execute command "/build/lollypop/bin/revision.sh".

A full log can be found at /build/lollypop/build/meson-logs/meson-log.txt

@jonafato
Copy link
Contributor Author

jonafato commented Nov 8, 2020

This update depends on the libhandy upgrade made in #98316. For some reason I only saw that in staging-next, but I see that it's in staging as well; should this change target staging instead?

Not sure why there was a build failure, it built locally for me. I'm rebuilding against staging now to double check.

@jonafato
Copy link
Contributor Author

jonafato commented Nov 8, 2020

It builds and runs for me locally on latest staging as well.

@worldofpeace worldofpeace changed the base branch from staging-next to staging November 9, 2020 02:10
@worldofpeace worldofpeace changed the base branch from staging to staging-next November 9, 2020 02:10
@jonafato jonafato deleted the lollypop-1.4.5 branch November 9, 2020 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonafato @SuperSandro2000 @worldofpeace