Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nuspell: 4.0.1 -> 4.2.0 #104291

Merged
merged 1 commit into from Dec 22, 2020
Merged

nuspell: 4.0.1 -> 4.2.0 #104291

merged 1 commit into from Dec 22, 2020

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Nov 19, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from fpletz November 19, 2020 17:04
omasanori
omasanori approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@omasanori omasanori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nix path-info -S

/nix/store/kp07g7dikb9my3x67l43zqpp1z4w2jp6-nuspell-4.0.1	   92477088
/nix/store/6sq7cx9vzdxzjppsnpkl4w7c9w32irhc-nuspell-4.1.0	   92504448

Result of nixpkgs-review pr 104291 1

1 package built:
  • nuspell
  • system: "x86_64-linux"
  • host os: Linux 4.19.155-1.pvops.qubes.x86_64, Fedora, 32 (Thirty Two)
  • multi-user?: no
  • sandbox: yes
  • version: nix-env (Nix) 2.4pre20201118_79aa7d9
  • channels(user): "nixpkgs-21.03pre252431.4f3475b113c"
  • nixpkgs: /home/user/.nix-defexpr/channels/nixpkgs

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/291

@bbigras bbigras changed the title nuspell: 4.0.1 -> 4.1.0 nuspell: 4.0.1 -> 4.2.0 Dec 14, 2020
@bbigras
Copy link
Contributor Author

bbigras commented Dec 14, 2020

Updated to 4.2.0. Boost is not needed anymore

@bbigras
Copy link
Contributor Author

bbigras commented Dec 15, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin label Dec 15, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Dec 15, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@avdv
Copy link
Member

avdv commented Dec 18, 2020

Result of nixpkgs-review pr 104291 1

1 package built:
  • nuspell

@marvin-mk2
Copy link

marvin-mk2 bot commented Dec 21, 2020

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be put back in the needs_reviewer queue in one day.

avdv
avdv approved these changes Dec 21, 2020
View reviewed changes
Copy link
Member

@avdv avdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/300

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104291 run on x86_64-linux 1

1 package built:
  • nuspell

@SuperSandro2000 SuperSandro2000 merged commit 747ead1 into NixOS:master Dec 22, 2020
@bbigras
Copy link
Contributor Author

bbigras commented Dec 22, 2020

Thanks!

@bbigras bbigras deleted the nuspell branch December 22, 2020 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omasanori omasanori omasanori approved these changes

@avdv avdv avdv approved these changes

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bbigras @nixos-discourse @avdv @SuperSandro2000 @omasanori