Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asterisk: Bump all packages #104290

Merged
merged 1 commit into from Nov 19, 2020
Merged

Conversation

dasJ
Copy link
Member

@dasJ dasJ commented Nov 19, 2020

Motivation for this change

Security update: https://issues.asterisk.org/jira/browse/ASTERISK-29057

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dasJ dasJ requested a review from ajs124 November 19, 2020 16:14
@dasJ dasJ added 8.has: port to stable A PR already has a backport to the stable release. 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. and removed 8.has: port to stable A PR already has a backport to the stable release. labels Nov 19, 2020
@ofborg ofborg bot requested review from DerTim1 and yorickvP November 19, 2020 17:10
@ajs124 ajs124 merged commit 48c25e5 into NixOS:master Nov 19, 2020
@ajs124 ajs124 deleted the upd/asterisk3 branch November 19, 2020 21:55
erictapen pushed a commit that referenced this pull request Jan 13, 2021
(cherry picked from commit 1027c06)

Backported as this is an security update:
https://issues.asterisk.org/jira/browse/ASTERISK-29057

See also #104290
@erictapen
Copy link
Member

Backported in 875bcac.

I tested the backport by building .#asterisk .#asterisk-lts .#asterisk-stable .#asterisk_13 .#asterisk_16 .#asterisk_17.

@dasJ could you please include version numbers into the commit message? You could split it into several commits or do something like asterisk: 13.37.1 -> 13.38.0, 16.14.1 -> 16.15.0, .... That makes maintaining backports much easier, compared to finding the right commit in a list of asterisk: Bump all packages.

@erictapen erictapen added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants