New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework pack pattern annotation generation #89
Comments
Follow up on pack patterns in children pb_tyesAs discussed in the PR, the pack pattern auto-generation affects also the children pb types when building a top-level pb_type. The image above represents a much simplified real case in the QL devices. At generation time of the leaf pb_types, v2x is not aware of the fact that a pack pattern is required to connect and correctly pack together with the C_FRAG and Q_FRAG pb_types, which are generated before the top-level pb_type. Only when the In the above example, there are four different pack patterns to be added, one for each possible path, as follows:
The problem stands in the fact that the pack pattern is not present in the original children pb_types. |
There needs to be four pack patterns generated which group together the following sets of bels;
|
@mithro @acomodi I've done some work to make The idea is to have In the picture above the The code I've written automatically duplicates pack-patterns whenever there are multiple paths possible for the initially annotated connection. Each path is meant to span from and to a leaf pb_type (no carry chain pack patterns supported yet). For now multiple pb_type modes are supported as well as The expansion can go both "up" and "down" the signal path. Any feedback would be appreciated. |
The pack pattern annotation generation should be done in following steps;
pack
attribute.pack
attribute from any path which goes to a top level port.Test cases;
The text was updated successfully, but these errors were encountered: