Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixUnstable: pre20201102_550e11f -> pre20201118_79aa7d9 #104289

Merged
merged 1 commit into from Nov 21, 2020
Merged

nixUnstable: pre20201102_550e11f -> pre20201118_79aa7d9 #104289

merged 1 commit into from Nov 21, 2020

Conversation

roberth
Copy link
Member

@roberth roberth commented Nov 19, 2020

Motivation for this change

Update nixUnstable to a version that doesn't crash as much.

Replaces, closes #102932. To quote it:
Fix a memory corruption and deadlock caused by new constant-memory source filtering implementation (+ fix implementation error)
Fix nix-copy-closure with drvs
Fix a varargs error in an error message (also a crash?)

Since then, more fixes have landed. Hopefully not much has broken.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@roberth roberth requested a review from grahamc November 19, 2020 16:12
@roberth roberth mentioned this pull request Nov 19, 2020
Closed
10 tasks
@roberth roberth added the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 19, 2020
@ofborg ofborg bot requested a review from edolstra November 19, 2020 16:45
@roberth roberth changed the title nixUnstable: pre20201102_550e11f -> pre20201119_79aa7d9 nixUnstable: pre20201102_550e11f -> pre20201118_79aa7d9 Nov 20, 2020
@roberth roberth force-pushed the update-nixUnstable-2020-11-19 branch 2 times, most recently from d161ad0 to d707223 Compare November 20, 2020 12:09
@roberth @edolstra
nixUnstable: pre20201102_550e11f -> pre20201118_79aa7d9
4dd5da0 
Co-authored-by: Eelco Dolstra <edolstra@gmail.com>
@roberth roberth force-pushed the update-nixUnstable-2020-11-19 branch from d707223 to 4dd5da0 Compare November 20, 2020 12:11
@ofborg ofborg bot requested a review from edolstra November 20, 2020 12:28
@roberth roberth merged commit 18506b7 into NixOS:master Nov 21, 2020
@Ma27
Copy link
Member

Ma27 commented Nov 21, 2020

@roberth would you mind taking care of the backport as well? :)

@Ma27
Copy link
Member

Ma27 commented Nov 21, 2020

For the record, ported to stable as 7bf4729.

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Nov 21, 2020
@martinetd martinetd mentioned this pull request Dec 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@grahamc grahamc Awaiting requested review from grahamc

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@roberth @Ma27 @edolstra