Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] nixos/release-small: add amazonImage #104323

Merged
merged 1 commit into from Nov 19, 2020
Merged

[20.09] nixos/release-small: add amazonImage #104323

merged 1 commit into from Nov 19, 2020

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Nov 19, 2020

fixup breakage from #104193

(cherry picked from commit 1ef139f)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@grahamc
nixos/release-small: add amazonImage
f80410d 
fixup breakage from NixOS#104193

(cherry picked from commit 1ef139f)
@dasJ dasJ added 8.has: port to stable A PR already has a backport to the stable release. 1.severity: channel blocker Blocks a channel labels Nov 19, 2020
@grahamc
Copy link
Member Author

grahamc commented Nov 19, 2020 

warning: unknown setting 'extra-sandbox-paths'
warning: you did not specify '--add-root'; the result might be removed by the garbage collector
/nix/store/c8mbqaw5kjd92yaw6pmx2bhp1y0hy0wp-nixos-amazon-image-20.09beta-185971.gfedcba-x86_64-linux.drv

@grahamc grahamc merged commit 9192f08 into NixOS:release-20.09 Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: channel blocker Blocks a channel 6.topic: nixos 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@grahamc @dasJ