Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] mariadb: 10.4.15 -> 10.4.17 #104284

Merged
merged 1 commit into from Jan 10, 2021
Merged

[20.09] mariadb: 10.4.15 -> 10.4.17 #104284

merged 1 commit into from Jan 10, 2021

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Nov 19, 2020

https://mariadb.com/kb/en/mariadb-10416-release-notes/
https://mariadb.com/kb/en/mariadb-10417-release-notes/

Motivation for this change

Upstream release.

cc @Izorkin

I'd suggest backporting and to keep bumping this in 20.09, even after master has been switched to 10.5.x

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from thoughtpolice November 19, 2020 15:47
@ajs124 ajs124 mentioned this pull request Nov 19, 2020
Merged
10 tasks
@ajs124 ajs124 changed the base branch from master to release-20.09 November 19, 2020 20:55
@ajs124 ajs124 requested a review from zowoq as a code owner November 19, 2020 20:55
@joachifm joachifm removed their request for review November 21, 2020 14:33
@hax404
Copy link
Contributor

hax404 commented Jan 9, 2021

This PR fixes the following CVEs:

hax404
hax404 approved these changes Jan 10, 2021
View reviewed changes
Copy link
Contributor

@hax404 hax404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problems noticed by tests from nixos/tests/mysql/

@mweinelt mweinelt changed the title mariadb: 10.4.15 -> 10.4.17 [20.09] mariadb: 10.4.15 -> 10.4.17 Jan 10, 2021
@mweinelt mweinelt added the 8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. label Jan 10, 2021
@mweinelt
Copy link
Member

This release introduced an InnoDB data corruption bug (MDEV-24096). If any InnoDB tables contain indexed virtual columns or unique indexes on BLOB or TEXT columns, any InnoDB tables or tablespaces may become irrepairably corrupted.

Happy we didn't jump on the 10.4.16 release then.

@mweinelt mweinelt merged commit ffce5a0 into NixOS:release-20.09 Jan 10, 2021
@ajs124 ajs124 deleted the upd/mariadb branch January 11, 2021 02:20
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/pr-merging-without-hydra/11103/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@hax404 hax404 hax404 approved these changes

@Izorkin Izorkin Izorkin approved these changes

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@adisbladis adisbladis Awaiting requested review from adisbladis

@andir andir Awaiting requested review from andir

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@edwtjo edwtjo Awaiting requested review from edwtjo

@kalbasit kalbasit Awaiting requested review from kalbasit

@Lassulus Lassulus Awaiting requested review from Lassulus

@LnL7 LnL7 Awaiting requested review from LnL7

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@Mic92 Mic92 Awaiting requested review from Mic92

@mmahut mmahut Awaiting requested review from mmahut

@peti peti Awaiting requested review from peti

@tfc tfc Awaiting requested review from tfc

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
1.severity: security 8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ajs124 @hax404 @mweinelt @nixos-discourse @Izorkin @FRidh