Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.breezy: remove dulwich optional dependency #104309

Closed
wants to merge 1 commit into from
Closed

python3Packages.breezy: remove dulwich optional dependency #104309

wants to merge 1 commit into from

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 19, 2020 •
edited

Motivation for this change

related: #104275

they mention:

    # Technically, Breezy works without these two dependencies too. But there's
    # no way to enable them by default and let users opt out.

So, I just removed it for them since dulwich likes to fall on the segfault sword.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor Author

this and #104307 should fix hydra-unstable

@ofborg ofborg bot requested a review from marsam November 19, 2020 21:28
@jonringer
Copy link
Contributor Author

so those comments were a lie:

$ ../result/bin/bzr init
brz: ERROR: Unable to import library "dulwich": bzr-git: Please install dulwich, https://www.dulwich.io/

@jonringer jonringer marked this pull request as draft November 19, 2020 22:44
@jonringer
Copy link
Contributor Author

closing in favor of #104327

@jonringer jonringer closed this Nov 20, 2020
@jonringer jonringer deleted the fix-breezy branch November 20, 2020 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@marsam marsam Awaiting requested review from marsam

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer