Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

microcodeIntel: 20201112 -> 20201118 #104303

Merged
merged 1 commit into from Nov 19, 2020
Merged

microcodeIntel: 20201112 -> 20201118 #104303

merged 1 commit into from Nov 19, 2020

Conversation

mweinelt
Copy link
Member

Motivation for this change

Fixes a regression on some "OEM platforms".

Relates to #104301

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt
microcodeIntel: 20201112 -> 20201118
5928d66 
Fixes a regression on some "OEM platforms".

Relates to NixOS#104301
@mweinelt mweinelt mentioned this pull request Nov 19, 2020
Closed
@ofborg ofborg bot requested a review from andir November 19, 2020 20:00
@mitchmindtree
Copy link
Member

After testing this locally on my Dell XPS 13 9310 I can confirm that this appears to fix #104301.

To test, I cloned this branch and did something along these lines:

$ export NIXPKGS=/path/to/this/branch
$ sudo nixos-rebuild -I $NIXPKGS switch

I waited for the build to complete, then rebooted, and the system now appears to boot correctly.

Thanks for the speedy PR!

@mweinelt mweinelt merged commit bd540a3 into NixOS:master Nov 19, 2020
@mweinelt mweinelt deleted the microcodeIntel branch November 27, 2020 19:59
@mweinelt
Copy link
Member Author

mweinelt commented Nov 27, 2020 •
edited

Ported to 20.09 in e111e9d
Ported to 20.03 in df25e21

Sorry everyone, I forgot to backport this in time.

@mweinelt mweinelt mentioned this pull request Nov 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andir andir Awaiting requested review from andir

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mweinelt @mitchmindtree