FontAccess: Chrome UI for a chooser #26579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 19, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2543603
branch
3 times, most recently
from
85b35e8
to
c6fe8bb
Compare
This CL implements a Chrome UI that allows users to pick one or more fonts, resulting from a request originating from a Blink API call. This change implements a multi-select chooser that offers the option to "import" fonts to sites as well as the ability to cancel. It is implemented as a permission bubble initially. Fixed: 1138621 Change-Id: I9f4a0bd7a990823d2de0c19372cbedc4e811d7d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543603 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by: Joshua Bell <jsbell@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#829910}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2543603
branch
from
c6fe8bb
to
1a1c75a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL implements a Chrome UI that allows users to pick one or more
fonts, resulting from a request originating from a Blink API call.
This change implements a multi-select chooser that offers the option to
"import" fonts to sites as well as the ability to cancel. It is
implemented as a permission bubble initially.
Fixed: 1138621
Change-Id: I9f4a0bd7a990823d2de0c19372cbedc4e811d7d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543603
Commit-Queue: Olivier Yiptong <oyiptong@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829910}