Fix fetch sources for five packages: ghc, xmlto, libdevil, cyrus-sasl, python3Packages.memcached #103542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please do not use tarballs.nixos.org in src URLs. tarballs.nixos.org is a cache, not an authority. This patch differs from the one in tarballs.nixos.org only in source code comments.
chkno
requested review from
cdepillabout,
FRidh and
jonringer
as code owners
ajs124
reviewed
Nov 12, 2020
| src = fetchurl { | ||
| url = "http://fedorahosted.org/releases/x/m/xmlto/${name}.tar.bz2"; |
There was a problem hiding this comment.
Seems like there is a handful of other packages referencing fedorahosted.org. Seeing as that was retired, those also need this fixed (eventually).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Make these packages fetchable. Currently, these builds are only working because these sources are cached in tarballs.nixos.org.
Hashes are preserved where possible (4 out of 5).
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)