Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

f2fs-tools: 1.13.0 -> 1.14.0 [20.09] #103527

Merged
merged 1 commit into from Nov 12, 2020
Merged

f2fs-tools: 1.13.0 -> 1.14.0 [20.09] #103527

merged 1 commit into from Nov 12, 2020

Conversation

redvers
Copy link
Member

@redvers redvers commented Nov 12, 2020

Allow use of 'compression' option on volume creation, supported at
mount-time in kernels 5.6+

(cherry picked from commit b467630)

Motivation for this change

Addresses 5 CVEs: Issue roundup: #101150

     nixos-20.09: f2fs-tools-1.13.0 (1.13.0): pkgs/tools/filesystems/f2fs-tools/default.nix:20
       Issues: 101150 (Containing 5 CVE(s)) Hash:NwPunTqpedk5yfSaIEOgMg==
nixpkgs-unstable: f2fs-tools-1.14.0 (1.14.0): pkgs/tools/filesystems/f2fs-tools/default.nix:20
       Issues: 
  CVE Block
  NwPunTqpedk5yfSaIEOgMg== => CVE-2020-6104,CVE-2020-6105,CVE-2020-6106
                              CVE-2020-6107,CVE-2020-6108

Review of changelog doesn't show any differences in existing usage.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@anoother @redvers
f2fs-tools: 1.13.0 -> 1.14.0
06ded01 
Allow use of 'compression' option on volume creation, supported at
mount-time in kernels 5.6+

(cherry picked from commit b467630)
@ofborg ofborg bot requested review from jagajaga and ehmry November 12, 2020 02:16
@redvers redvers changed the base branch from nixos-20.09 to release-20.09 November 12, 2020 02:37
@redvers redvers changed the title f2fs-tools: 1.13.0 -> 1.14.0 f2fs-tools: 1.13.0 -> 1.14.0 [20.09] Nov 12, 2020
@jagajaga jagajaga merged commit e642130 into NixOS:release-20.09 Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jagajaga jagajaga Awaiting requested review from jagajaga

@ehmry ehmry Awaiting requested review from ehmry

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@redvers @jagajaga @anoother