Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tor-browser-bundle-bin: Fix extension path. Fixes NoScript. #103570

Merged
merged 1 commit into from Nov 12, 2020
Merged

tor-browser-bundle-bin: Fix extension path. Fixes NoScript. #103570

merged 1 commit into from Nov 12, 2020

Conversation

chkno
Copy link
Member

@chkno chkno commented Nov 12, 2020

Motivation for this change

Fixes #83096

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    841,541,864 → 841,542,040
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

FYI @yurkobb , @xaverdh , @joachifm, @mehlon

@chkno
Copy link
Member Author

chkno commented Nov 12, 2020

+other tor-browser-bundle-bin maintainers: @doublec @hax404 @KarlJoad @matejc @offlinehacker @scaredmushroom @thoughtpolice

@xaverdh
Copy link
Contributor

xaverdh commented Nov 12, 2020

For reference, the folder used here is ESR specific and currently documented here: https://support.mozilla.org/en-US/kb/deploying-firefox-with-extensions

@xaverdh xaverdh mentioned this pull request Nov 12, 2020
Closed
10 tasks
@chkno
Copy link
Member Author

chkno commented Nov 12, 2020

For reference, the folder used here is ESR specific and currently documented here: https://support.mozilla.org/en-US/kb/deploying-firefox-with-extensions

Thanks! I added this link to the buildCommand comment to aid future maintainers. (I just found this path with strace. Good to know that it's officially supported. :)

@joachifm joachifm merged commit b719eb3 into NixOS:master Nov 12, 2020
@xaverdh
Copy link
Contributor

xaverdh commented Nov 13, 2020

this needs a backport btw

@erictapen
Copy link
Member

Backported:
20.09: 306596c
20.03: 9315a5f

What I did to test: I set the security level to safest and verified that JS is disabled. For both channels on x86_64-linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tor Browser: add-ons disabled on start
4 participants
@chkno @xaverdh @erictapen @joachifm