Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/acpilight: add to packages #103531

Merged
merged 1 commit into from Nov 12, 2020
Merged

nixos/acpilight: add to packages #103531

merged 1 commit into from Nov 12, 2020

Conversation

ghost
Copy link

@ghost ghost commented Nov 12, 2020

Motivation for this change

When enabling module, acpilight should be installed system-wide similar to https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/programs/light.nix

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost
Copy link
Author

ghost commented Nov 12, 2020

cc @etu @Fuuzetsu

@ghost
Copy link
Author

ghost commented Nov 12, 2020

@etu Thank you!

@ghost ghost deleted the acpilight branch November 12, 2020 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant