Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] fastd: 19 -> 21 #103530

Merged
merged 1 commit into from Nov 23, 2020
Merged

[20.09] fastd: 19 -> 21 #103530

merged 1 commit into from Nov 23, 2020

Conversation

redvers
Copy link
Member

@redvers redvers commented Nov 12, 2020

(cherry picked from commit 5a4385d)

Motivation for this change

Addresses: #102785 - CVE-2020-27638

I have reviewed the release notes for v20 and v21.

  • The one operational change is specific to their openWRT implementation. (v20)
  • Rest are benign bugfixes. (v20)

v21 is listed as a critical update that all v20 users MUST update to.

https://fastd.readthedocs.io/en/stable/releases/v20.html
https://fastd.readthedocs.io/en/stable/releases/v21.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt @redvers
fastd: 19 -> 21
9ca27e1 
(cherry picked from commit 5a4385d)
@ofborg ofborg bot requested a review from fpletz November 12, 2020 02:32
@redvers redvers changed the base branch from nixos-20.09 to release-20.09 November 12, 2020 02:36
@redvers redvers changed the title fastd: 19 -> 21 fastd: 19 -> 21 [20.09] Nov 12, 2020
@SuperSandro2000 SuperSandro2000 changed the title fastd: 19 -> 21 [20.09] [20.09] fastd: 19 -> 21 Nov 23, 2020
@mweinelt
Copy link
Member

Result of nixpkgs-review pr 103530 1

1 package built:
  • fastd

@mweinelt mweinelt merged commit 1875cf4 into NixOS:release-20.09 Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@redvers @mweinelt @FRidh