ruby: check disallowed references with jitSupport disabled #103584
Conversation
| @@ -210,6 +210,8 @@ let | |||
| sed -i "s|'--with-baseruby=${baseruby}/bin/ruby'||" $rbConfig | |||
| ''; | |||
|
|
|||
| disallowedReferences = op (!jitSupport) stdenv.cc; | |||
There was a problem hiding this comment.
Maybe:
| disallowedReferences = op (!jitSupport) stdenv.cc; | |
| disallowedReferences = lib.optionals (!jitSupport) [ stdenv.cc stdenv.cc.cc ]; |
There was a problem hiding this comment.
Then I propose
disallowedRequisites = op (!jitSupport) stdenv.cc.cc;
Since that checks the transitive closure and stdenv.cc will have stdenv.cc.cc in its closure.
This makes it easier to detect regressions.
danieldk
force-pushed
the
ruby-check-disallowed-references
branch
from
d8292a8
to
b235552
Compare
There was a problem hiding this comment.
LGTM but I wonder if it'll actually be detected and fixed if at some point, a future version of ruby will add another point of reference to cc (not handled currently).. @lilyball thinks (I think) there should be a ruby derivation built by Hydra that doesn't reference cc.
I don't really have an opinion, I don't use Ruby (aside from one website that uses Jekyll for historical reasons). I just happened to see the topic on Discourse & it's usually good to match a |
|
OK. We can make another PR in the future, this is good enough as a start. |
Motivation for this change
This makes it easier to detect regressions.
cc @doronbehar
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)