Skip to content

haskellPackages.hail: relax cabal dependencies to unbreak #103579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2020
Merged

haskellPackages.hail: relax cabal dependencies to unbreak #103579

merged 1 commit into from
Nov 12, 2020
+3 −4

Conversation

blitz
Copy link
Contributor

@blitz blitz commented Nov 12, 2020 •
edited
Loading

The upstream version still contains very strict dependency
constraints. I've updated the patches to a version that relax these.
This unbreaks hail for me.

Open Question: How do I actually update hackage-packages.nix?

See james-preston/hail#16 for the upstream fix.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@peti

Sorry, something went wrong.

@blitz
haskellPackages.hail: relax cabal dependencies to unbreak
cd11c0c 
The upstream version still contains very strict dependency
constraints. I've updated the patches to a version that relax these.
This unbreaks hail for me.
@blitz blitz requested a review from cdepillabout as a code owner November 12, 2020 09:49
@blitz blitz requested review from peti and tfc November 12, 2020 09:49
@ofborg ofborg bot added 6.topic: haskell 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 12, 2020
@tfc tfc merged commit 2de6009 into NixOS:master Nov 12, 2020
@blitz blitz mentioned this pull request Nov 16, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout

@peti peti

@tfc tfc

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@blitz @tfc