Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/xidlehook: new service #103857

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Conversation

enolan
Copy link
Contributor

@enolan enolan commented Nov 15, 2020

I added a service for xidlehook so it can be automatically managed by systemd like xautolock is. We already had a package for it.

Motivation for this change

It's really annoying when the screen locks while I'm watching DS9 because I haven't moved the mouse.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I added a service for xidlehook so it can be automatically managed by systemd
like xautolock is. We already had a package for it.
@stale
Copy link

stale bot commented Jun 3, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 3, 2021
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-in-distress/3604/42

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 4, 2021
nixos/modules/services/x11/xidlehook.nix Outdated Show resolved Hide resolved
nixos/modules/services/x11/xidlehook.nix Outdated Show resolved Hide resolved
nixos/modules/services/x11/xidlehook.nix Outdated Show resolved Hide resolved
nixos/modules/services/x11/xidlehook.nix Outdated Show resolved Hide resolved
Co-authored-by: Anderson Torres <torres.anderson.85@protonmail.com>
@srid
Copy link
Contributor

srid commented Sep 11, 2021

Related #76063

@Alexnortung
Copy link
Contributor

I am still interested in this getting merged, is there anything that needs to be done?
And what should the decision be on which pull to merge? this or #76063?

@AndersonTorres
Copy link
Member

Squash the unneeded "I fixed my mistakes" commits.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 21, 2022
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024
@wegank wegank marked this pull request as draft March 25, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants