kenlm: init at unstable-2020-11-14 #103858
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvarWithoutBones
requested changes
Nov 18, 2020
znewman01
commented
Nov 18, 2020
There was a problem hiding this comment.
Thank you for the detailed review! (If you can't tell, I don't write a lot of Nix and cargo-culted much of this commit).
I've resolved all of your comments; in general, I did exactly as requested, except that I removed the "doCheck" entirely (there's no obvious test target in kenlm).
IvarWithoutBones
approved these changes
Nov 18, 2020
Comment on lines
+4
to
+5
| pname = "kenlm-unstable"; | ||
| version = "2020-11-03"; |
There was a problem hiding this comment.
Suggested change
| pname = "kenlm-unstable"; | |
| version = "2020-11-03"; | |
| pname = "kenlm"; | |
| version = "unstable-2020-11-03"; |
There was a problem hiding this comment.
@IvarWithoutBones suggested the opposite of this change and referred to #68518
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
SuperSandro2000
requested changes
Nov 7, 2022
| nativeBuildInputs = [ cmake ]; | ||
| buildInputs = [ boost eigen xz zlib bzip2 ]; | ||
|
|
||
| meta = with stdenv.lib; { |
There was a problem hiding this comment.
Suggested change
| meta = with stdenv.lib; { | |
| meta = with lib; { |
stale
bot
removed
2.status: stale
wegank
added
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
kenlmis a natural language processing tool for dealing with language models: estimating, filtering, and querying.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)