Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batik: 1.6 -> 1.13 #103838

Merged
merged 2 commits into from Nov 26, 2020
Merged

batik: 1.6 -> 1.13 #103838

merged 2 commits into from Nov 26, 2020

Conversation

braunse
Copy link
Contributor

@braunse braunse commented Nov 14, 2020

Motivation for this change

Fixes vulnerabilities:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marvin-mk2 marvin-mk2 bot added the marvin label Nov 14, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Nov 14, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@braunse
Copy link
Contributor Author

braunse commented Nov 14, 2020

/marvin opt-in
/status needs_reviewer

@braunse
Copy link
Contributor Author

braunse commented Nov 14, 2020

On Debian:

Result of nixpkgs-review pr 103838 1

1 package built:
  • batik

@braunse
Copy link
Contributor Author

braunse commented Nov 15, 2020

On NixOS:

Result of nixpkgs-review pr 103838 1

1 package built:
  • batik

pkgs/applications/graphics/batik/default.nix Outdated Show resolved Hide resolved
@marvin-mk2
Copy link

marvin-mk2 bot commented Nov 20, 2020

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be put back in the needs_reviewer queue in one day.

1 similar comment
@marvin-mk2
Copy link

marvin-mk2 bot commented Nov 23, 2020

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be put back in the needs_reviewer queue in one day.

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @delroth please replace the builder script with an install phase.
/status awaiting_changes

@braunse
Copy link
Contributor Author

braunse commented Nov 24, 2020

As @delroth please replace the builder script with an install phase.
/status awaiting_changes

I removed the builder script and replaced by a trivial installPhase.

@braunse
Copy link
Contributor Author

braunse commented Nov 24, 2020

Oops
/status awaiting_reviewer

@prusnak prusnak merged commit 8aa1ee3 into NixOS:master Nov 26, 2020
@braunse braunse deleted the batik-1.13 branch November 29, 2020 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants