Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.containers: 3.0 → 3.0.1 #103871

Merged
merged 2 commits into from Nov 22, 2020
Merged

ocamlPackages.containers: 3.0 → 3.0.1 #103871

merged 2 commits into from Nov 22, 2020

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Nov 15, 2020

Motivation for this change

Use Dune 2.
Fix: https://github.com/c-cube/ocaml-containers/blob/v3.0.1/CHANGELOG.md

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vbgl
Copy link
Contributor Author

vbgl commented Nov 20, 2020

@GrahamcOfBorg build ocamlPackages.containers-data ocamlPackages.tsort

@vbgl vbgl merged commit e286f0c into NixOS:master Nov 22, 2020
@vbgl vbgl deleted the ocaml-containers-3.0.1 branch November 22, 2020 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: ocaml 8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@vbgl