Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.aioextensions: init at 20.11.1517005 #103819

Merged
merged 1 commit into from Nov 18, 2020
Merged

pythonPackages.aioextensions: init at 20.11.1517005 #103819

merged 1 commit into from Nov 18, 2020

Conversation

kamadorueda
Copy link
Member

@kamadorueda kamadorueda commented Nov 14, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kamadorueda
Copy link
Member Author 

# Linux kamado 5.4.0-53-generic #59-Ubuntu SMP Wed Oct 21 09:38:44 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0
$ git worktree add /home/kamado/.cache/nixpkgs-review/rev-458a7ced196c73854d1fe9a8b3766275d70537e1/nixpkgs ee9dabbdcc465cd28a7c282bda240aaaa224dc08
Preparing worktree (detached HEAD ee9dabbdcc4)
Updating files: 100% (23192/23192), done.
HEAD is now at ee9dabbdcc4 Merge pull request #103806 from r-ryantm/auto-update/python3.7-sphinxcontrib-katex
$ nix-env -f /home/kamado/.cache/nixpkgs-review/rev-458a7ced196c73854d1fe9a8b3766275d70537e1/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit 458a7ced196c73854d1fe9a8b3766275d70537e1
Automatic merge went well; stopped before committing as requested
$ nix-env -f /home/kamado/.cache/nixpkgs-review/rev-458a7ced196c73854d1fe9a8b3766275d70537e1/nixpkgs -qaP --xml --out-path --show-trace --meta
2 packages added:
python37Packages.aioextensions (init at 20.9.2315218) python38Packages.aioextensions (init at 20.9.2315218)

$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/kamado/.cache/nixpkgs-review/rev-458a7ced196c73854d1fe9a8b3766275d70537e1/build.nix
[3 built, 0.0 MiB DL]
2 packages built:
python37Packages.aioextensions python38Packages.aioextensions

$ nix-shell /home/kamado/.cache/nixpkgs-review/rev-458a7ced196c73854d1fe9a8b3766275d70537e1/shell.nix

@kamadorueda kamadorueda changed the title pythonPackages.aioextensions: init at 20.9.2315218 pythonPackages.aioextensions: init at 20.11.1517005 Nov 18, 2020
@kamadorueda
Copy link
Member Author 

nixpkgs$ nix-review rev HEAD
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0
$ git worktree add /home/kamado/.cache/nixpkgs-review/rev-430422ae9e5583bae60f7b78abec0f9458fe5232/nixpkgs 7e25b7113271cf80eb0f950da2e1aa7b382eb268
Preparing worktree (detached HEAD 7e25b711327)
Updating files: 100% (23228/23228), done.
HEAD is now at 7e25b711327 nixos: use nativeBuildInputs in make- iso9660-image and system-tarball
$ nix-env -f /home/kamado/.cache/nixpkgs-review/rev-430422ae9e5583bae60f7b78abec0f9458fe5232/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit 430422ae9e5583bae60f7b78abec0f9458fe5232
Updating 7e25b711327..430422ae9e5
Fast-forward
 .../python-modules/aioextensions/default.nix   | 35 +++++++++++++++++++
 pkgs/top-level/python-packages.nix             |  2 ++
 2 files changed, 37 insertions(+)
 create mode 100644 pkgs/development/python-modules/aioextensions/default.nix
$ nix-env -f /home/kamado/.cache/nixpkgs-review/rev-430422ae9e5583bae60f7b78abec0f9458fe5232/nixpkgs -qaP --xml --out-path --show-trace --meta
2 packages added:
python37Packages.aioextensions (init at 20.11.1517005) python38Packages.aioextensions (init at 20.11.1517005)

$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/kamado/.cache/nixpkgs-review/rev-430422ae9e5583bae60f7b78abec0f9458fe5232/build.nix
[2 built, 0.0 MiB DL]
2 packages built:
python37Packages.aioextensions python38Packages.aioextensions

$ nix-shell /home/kamado/.cache/nixpkgs-review/rev-430422ae9e5583bae60f7b78abec0f9458fe5232/shell.nix

[nix-shell:~/.cache/nixpkgs-review/rev-430422ae9e5583bae60f7b78abec0f9458fe5232]$

jonringer
jonringer approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 103819 1

2 packages built:
  • python37Packages.aioextensions
  • python38Packages.aioextensions

@jonringer jonringer merged commit 04a641b into NixOS:master Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kamadorueda @SuperSandro2000 @jonringer