Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nvidia-x11: 450.66 -> 455.38 [20.09] #103834

Merged
merged 1 commit into from Nov 15, 2020
Merged

nvidia-x11: 450.66 -> 455.38 [20.09] #103834

merged 1 commit into from Nov 15, 2020

Conversation

dfoxfranke
Copy link
Contributor

Motivation for this change

nvidia-x11 versions 450.31 through 455.28 contain a serious performance regression that make my system nearly unusable. This is fixed in 455.38; the relevant changelog entry is "Fixed a performance regression in the NVIDIA X driver which affected some X11 RENDER extension use cases". I'd appreciate seeing this backported to 20.09, given that (absent #99323) it's very difficult to use a custom version of nvidia-x11 without completely forking nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dfoxfranke
Copy link
Contributor Author

cc @baracoder

@dfoxfranke dfoxfranke changed the title nvidia-x11: backport 455.38 to 20.09 nvidia-x11: 450.66 -> 455.38 [20.09] Nov 14, 2020
@dfoxfranke
Copy link
Contributor Author

cc @NixOS/backports

@veprbl veprbl merged commit 9d5ef2a into NixOS:release-20.09 Nov 15, 2020
@fabianhjr
Copy link
Member

Thanks for this backport, I had also been having issues (though, stability rather than performance) with the most recent 20.09 nvidia driver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baracoder baracoder baracoder approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dfoxfranke @fabianhjr @baracoder @veprbl