Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Openafs: drop 1.6; init 1.9 #103860

Closed
wants to merge 2 commits into from
Closed

Openafs: drop 1.6; init 1.9 #103860

wants to merge 2 commits into from

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Nov 15, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 changed the title Openafs next Openafs: drop 1.6; init 1.9 Nov 15, 2020
@Mic92 Mic92 mentioned this pull request Nov 15, 2020
Merged
10 tasks
@ofborg ofborg bot requested a review from maggesi November 15, 2020 03:10
@spacefrogg
Copy link
Contributor

You are re-introducing the server output. This leads to broken binaries in 1.8, as the path to the salvage binary is compiled into bos and bosserver binaries. Did you verify that this works in 1.9 or did you base your derivation on and older version?

@Mic92
Copy link
Member Author

Mic92 commented Nov 17, 2020

You are re-introducing the server output. This leads to broken binaries in 1.8, as the path to the salvage binary is compiled into bos and bosserver binaries. Did you verify that this works in 1.9 or did you base your derivation on and older version?

I only tested the client part.

@Mic92
Copy link
Member Author

Mic92 commented Nov 17, 2020

Let's close this one. It would need to include updates from #99379

@Mic92 Mic92 closed this Nov 17, 2020
@Mic92 Mic92 deleted the openafs-next branch July 23, 2021 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacefrogg spacefrogg Awaiting requested review from spacefrogg

@maggesi maggesi Awaiting requested review from maggesi

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @spacefrogg