Skip to content

nixos/factorio: add openFirewall option #103821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 24, 2020
Merged

nixos/factorio: add openFirewall option #103821

merged 2 commits into from
Nov 24, 2020

Conversation

Stekke
Copy link
Contributor

@Stekke Stekke commented Nov 14, 2020

Motivation for this change

According to the nixpkgs manual in "20.4. New modules" services should not open ports in the firewall by default .
However the factorio module currently does this, and is preventing me from creating more strict firewall rules.
Worse still, the factorio module offers no option to disable this behavior.

This pr adds the openFirewall option, set to true by default.
Thereby existing setups remain working and this would allows easy backporting of this commit to nixos 20.09.
But people who want to setup more complicated firewall rules can do so, without interference from the factorio module using the openFirewall option.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 14, 2020
Copy link
Member

@erictapen erictapen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, that is really bad behaviour of the factorio module.

Stijn DW added 2 commits November 24, 2020 20:57

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Member

@erictapen erictapen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@erictapen erictapen merged commit 3d3bcc5 into NixOS:master Nov 24, 2020
@erictapen
Copy link
Member

Backport: d31c86b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants