nixos/factorio: add openFirewall option #103821
Merged
+8
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
According to the nixpkgs manual in "20.4. New modules" services should not open ports in the firewall by default .
However the factorio module currently does this, and is preventing me from creating more strict firewall rules.
Worse still, the factorio module offers no option to disable this behavior.
This pr adds the openFirewall option, set to true by default.
Thereby existing setups remain working and this would allows easy backporting of this commit to nixos 20.09.
But people who want to setup more complicated firewall rules can do so, without interference from the factorio module using the openFirewall option.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)