Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvm_11: Disable checks on musl libc hosts #103846

Merged
merged 1 commit into from Jan 18, 2021
Merged

llvm_11: Disable checks on musl libc hosts #103846

merged 1 commit into from Jan 18, 2021

Conversation

kampka
Copy link
Contributor

@kampka kampka commented Nov 14, 2020

Motivation for this change

When building llvm_11 with musl libc, the checks fail.

llvm> Failed Tests (8):                                                                         
llvm>   LLVM :: CodeGen/Hexagon/csr-stubs-spill-threshold.ll                                    
llvm>   LLVM :: CodeGen/Hexagon/long-calls.ll                                                   
llvm>   LLVM :: CodeGen/Hexagon/mlong-calls.ll                                                  
llvm>   LLVM :: CodeGen/Hexagon/pic-regusage.ll                                                 
llvm>   LLVM :: CodeGen/Hexagon/runtime-stkchk.ll                                               
llvm>   LLVM :: CodeGen/Hexagon/swp-memrefs-epilog.ll                                     
llvm>   LLVM :: CodeGen/Hexagon/vararg-formal.ll                                          
llvm>   LLVM :: ExecutionEngine/Interpreter/intrinsics.ll                                 
llvm> Testing Time: 507.14s                                                                     
llvm>   Unsupported      :   995                                                                
llvm>   Passed           : 37262                                                                
llvm>   Expectedly Failed:   149                                                                
llvm>   Failed           :     8                                                                
llvm> 1 warning(s) in tests

Hence, I propose disabling the checks on musl hosts.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kampka
Copy link
Contributor Author

kampka commented Nov 14, 2020

@GrahamcOfBorg build pkgsMusl.llvm_11

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/383

@kampka
Copy link
Contributor Author

kampka commented Nov 24, 2020

@matthewbauer since I cannot overwrite this easily, I would really appreciate a quick review :)

@AndersonTorres
Copy link
Member

Is this an upstream bug?

@kampka
Copy link
Contributor Author

kampka commented Nov 25, 2020 •
edited

Is this an upstream bug?

I would go with yes, but not sure which upstream.
Honestly, I don't feel qualified to comment.

@Mic92
Copy link
Member

Mic92 commented Jan 18, 2021

@dtzWill does upstream llvm test with musl as well or only glibc?

@Mic92 Mic92 merged commit 1881e81 into NixOS:master Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kampka @nixos-discourse @AndersonTorres @Mic92