Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transition from paperspace to gradient #103841

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

freezeboy
Copy link
Contributor

Motivation for this change

This PR contains some changes to resolve the reverse dependencies broken by the automatic PR #103814.

Upstream paperspace has worked to rewrite its SDK which involves an update of the complete stack. The dangerous this here is this update includes wheel and numpy (even though for this one, it is a revision update).

If you want to run nixpkgs-review, prepare for a big build I guess, I compiled the packages inside this PR only.

This will not compile before PR #103814 is merged.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@freezeboy
Copy link
Contributor Author

Now hyperopt has been updated, this PR should be building correctly

Copy link
Member

@thoughtpolice thoughtpolice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but you'll definitely need to retarget this to be based on the staging branch instead, because it will effectively rebuild the world. We can't merge this until then, so I'm just putting in a soft Request Changes — other than that your changes look fine to me, but someone like Jon or Frederik should take a look.

Note that GitHub handles moving PRs onto new base branches very poorly (so poorly, in fact, that I cannot even describe how to do it properly; everybody messes it up completely for a reason, I suppose!) and it often ends up pinging hundreds of maintainers in the process, so you might actually want to just close this PR and open a new one...

@freezeboy
Copy link
Contributor Author

Wouldn't it be enough to rebase on staging on my side then push force here?

@freezeboy
Copy link
Contributor Author

Ok rebased on staging, looks good to me in terms of PR content

It seems numpy world-rebuild was already part of staging, so it vanished for this PR

@rmcgibbo
Copy link
Contributor

Result of nixpkgs-review pr 103841 run on x86_64-linux 1

13 packages failed to build:
  • apache-airflow (python37Packages.apache-airflow)
  • google-music-scripts
  • python37Packages.dftfit
  • python37Packages.google-music
  • python37Packages.google-music-proto
  • python37Packages.hug
  • python38Packages.dftfit
  • python38Packages.google-music
  • python38Packages.google-music-proto
  • python38Packages.hug
  • python39Packages.dataclasses-json
  • python39Packages.google-music-proto
  • python39Packages.hug
45 packages built:
  • esphome
  • flashfocus
  • platformio
  • python37Packages.apispec
  • python37Packages.dataclasses-json
  • python37Packages.flask-appbuilder
  • python37Packages.flask_marshmallow
  • python37Packages.gradient
  • python37Packages.gradient-utils
  • python37Packages.halo
  • python37Packages.log-symbols
  • python37Packages.marshmallow
  • python37Packages.marshmallow-enum
  • python37Packages.marshmallow-polyfield
  • python37Packages.marshmallow-sqlalchemy
  • python37Packages.marshmallow2
  • python37Packages.spinners
  • python38Packages.apispec
  • python38Packages.dataclasses-json
  • python38Packages.flask-appbuilder
  • python38Packages.flask_marshmallow
  • python38Packages.gradient
  • python38Packages.gradient-utils
  • python38Packages.halo
  • python38Packages.log-symbols
  • python38Packages.marshmallow
  • python38Packages.marshmallow-enum
  • python38Packages.marshmallow-polyfield
  • python38Packages.marshmallow-sqlalchemy
  • python38Packages.marshmallow2
  • python38Packages.spinners
  • python39Packages.apispec
  • python39Packages.flask-appbuilder
  • python39Packages.flask_marshmallow
  • python39Packages.gradient
  • python39Packages.gradient-utils
  • python39Packages.halo
  • python39Packages.log-symbols
  • python39Packages.marshmallow
  • python39Packages.marshmallow-enum
  • python39Packages.marshmallow-polyfield
  • python39Packages.marshmallow-sqlalchemy
  • python39Packages.marshmallow2
  • python39Packages.spinners
  • sublime-music


# tries to use /homeless-shelter to mimic container usage, etc
doCheck = false;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change


# tries to use /homeless-shelter to mimic container usage, etc
doCheck = false;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@SuperSandro2000
Copy link
Member

Please either execute tests for those packages or add doCheck = false; and pythonImportsCheck.

python38Packages.marshmallow.log                                                                                                                                                            190:Ran 0 tests in 0.000s                                                                                                                                                                                                                                                                                                                                                               sublime-music.log                                                                                                                                                                           487:Ran 0 tests in 0.000s                                                                                                                                                                                                                                                                                                                                                               python37Packages.marshmallow2.log                                                                                                                                                           206:Ran 0 tests in 0.000s                                                                                                                                                                                                                                                                                                                                                               python39Packages.marshmallow2.log                                                                                                                                                           206:Ran 0 tests in 0.000s                                                                                                                                                                                                                                                                                                                                                               python39Packages.gradient-utils.log                                                                                                                                                         153:Ran 0 tests in 0.000s                                                                                                                                                                                                                                                                                                                                                               python39Packages.marshmallow.log                                                                                                                                                            190:Ran 0 tests in 0.000s                                                                                                                                                                                                                                                                                                                                                               python38Packages.gradient-utils.log                                                                                                                                                         153:Ran 0 tests in 0.000s                                                                                                                                                                                                                                                                                                                                                               python38Packages.dataclasses-json.log                                                                                                                                                       159:Ran 0 tests in 0.000s                                                                                                                                                                                                                                                                                                                                                               python37Packages.marshmallow.log                                                                                                                                                            190:Ran 0 tests in 0.000s                                                                                                                                                                                                                                                                                                                                                               python37Packages.dataclasses-json.log                                                                                                                                                       159:Ran 0 tests in 0.000s                                                                                                                                                                                                                                                                                                                                                               python38Packages.marshmallow2.log                                                                                                                                                           206:Ran 0 tests in 0.000s                                                                                                                                                                                                                                                                                                                                                               python37Packages.gradient-utils.log                                                                                                                                                         153:Ran 0 tests in 0.000s

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 103841 run on x86_64-linux 1

12 packages failed to build:
  • google-music-scripts
  • python37Packages.dftfit
  • python37Packages.google-music
  • python37Packages.google-music-proto
  • python37Packages.hug
  • python38Packages.dftfit
  • python38Packages.google-music
  • python38Packages.google-music-proto
  • python38Packages.hug
  • python39Packages.dataclasses-json
  • python39Packages.google-music-proto
  • python39Packages.hug
46 packages built:
  • apache-airflow (python37Packages.apache-airflow)
  • esphome
  • flashfocus
  • platformio
  • python37Packages.apispec
  • python37Packages.dataclasses-json
  • python37Packages.flask-appbuilder
  • python37Packages.flask_marshmallow
  • python37Packages.gradient
  • python37Packages.gradient-utils
  • python37Packages.halo
  • python37Packages.log-symbols
  • python37Packages.marshmallow
  • python37Packages.marshmallow-enum
  • python37Packages.marshmallow-polyfield
  • python37Packages.marshmallow-sqlalchemy
  • python37Packages.marshmallow2
  • python37Packages.spinners
  • python38Packages.apispec
  • python38Packages.dataclasses-json
  • python38Packages.flask-appbuilder
  • python38Packages.flask_marshmallow
  • python38Packages.gradient
  • python38Packages.gradient-utils
  • python38Packages.halo
  • python38Packages.log-symbols
  • python38Packages.marshmallow
  • python38Packages.marshmallow-enum
  • python38Packages.marshmallow-polyfield
  • python38Packages.marshmallow-sqlalchemy
  • python38Packages.marshmallow2
  • python38Packages.spinners
  • python39Packages.apispec
  • python39Packages.flask-appbuilder
  • python39Packages.flask_marshmallow
  • python39Packages.gradient
  • python39Packages.gradient-utils
  • python39Packages.halo
  • python39Packages.log-symbols
  • python39Packages.marshmallow
  • python39Packages.marshmallow-enum
  • python39Packages.marshmallow-polyfield
  • python39Packages.marshmallow-sqlalchemy
  • python39Packages.marshmallow2
  • python39Packages.spinners
  • sublime-music

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 103841 run on x86_64-darwin 1

4 packages marked as broken and skipped:
  • python37Packages.dftfit
  • python38Packages.dftfit
  • python39Packages.google-music
  • sublime-music
11 packages failed to build:
  • apache-airflow (python37Packages.apache-airflow)
  • google-music-scripts
  • python37Packages.google-music
  • python37Packages.google-music-proto
  • python37Packages.hug
  • python38Packages.google-music
  • python38Packages.google-music-proto
  • python38Packages.hug
  • python39Packages.dataclasses-json
  • python39Packages.google-music-proto
  • python39Packages.hug
41 packages built:
  • python37Packages.apispec
  • python37Packages.dataclasses-json
  • python37Packages.flask-appbuilder
  • python37Packages.flask_marshmallow
  • python37Packages.gradient
  • python37Packages.gradient-utils
  • python37Packages.halo
  • python37Packages.log-symbols
  • python37Packages.marshmallow
  • python37Packages.marshmallow-enum
  • python37Packages.marshmallow-polyfield
  • python37Packages.marshmallow-sqlalchemy
  • python37Packages.marshmallow2
  • python37Packages.spinners
  • python38Packages.apispec
  • python38Packages.dataclasses-json
  • python38Packages.flask-appbuilder
  • python38Packages.flask_marshmallow
  • python38Packages.gradient
  • python38Packages.gradient-utils
  • python38Packages.halo
  • python38Packages.log-symbols
  • python38Packages.marshmallow
  • python38Packages.marshmallow-enum
  • python38Packages.marshmallow-polyfield
  • python38Packages.marshmallow-sqlalchemy
  • python38Packages.marshmallow2
  • python38Packages.spinners
  • python39Packages.apispec
  • python39Packages.flask-appbuilder
  • python39Packages.flask_marshmallow
  • python39Packages.gradient
  • python39Packages.gradient-utils
  • python39Packages.halo
  • python39Packages.log-symbols
  • python39Packages.marshmallow
  • python39Packages.marshmallow-enum
  • python39Packages.marshmallow-polyfield
  • python39Packages.marshmallow-sqlalchemy
  • python39Packages.marshmallow2
  • python39Packages.spinners

@stale
Copy link

stale bot commented Jul 20, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 20, 2021
@wegank wegank marked this pull request as draft March 20, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants