-
-
Notifications
You must be signed in to change notification settings - Fork 15.5k
transition from paperspace to gradient #103841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bd5b388
to
9282ac6
Compare
Now hyperopt has been updated, this PR should be building correctly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, but you'll definitely need to retarget this to be based on the staging
branch instead, because it will effectively rebuild the world. We can't merge this until then, so I'm just putting in a soft Request Changes
— other than that your changes look fine to me, but someone like Jon or Frederik should take a look.
Note that GitHub handles moving PRs onto new base branches very poorly (so poorly, in fact, that I cannot even describe how to do it properly; everybody messes it up completely for a reason, I suppose!) and it often ends up pinging hundreds of maintainers in the process, so you might actually want to just close this PR and open a new one...
Wouldn't it be enough to rebase on staging on my side then push force here? |
9282ac6
to
98a93d3
Compare
Ok rebased on staging, looks good to me in terms of PR content It seems numpy world-rebuild was already part of staging, so it vanished for this PR |
Result of 13 packages failed to build:
45 packages built:
|
|
||
# tries to use /homeless-shelter to mimic container usage, etc | ||
doCheck = false; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
# tries to use /homeless-shelter to mimic container usage, etc | ||
doCheck = false; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please either execute tests for those packages or add
|
Result of 12 packages failed to build:
46 packages built:
|
Result of 4 packages marked as broken and skipped:
11 packages failed to build:
41 packages built:
|
I marked this as stale due to inactivity. → More info |
Motivation for this change
This PR contains some changes to resolve the reverse dependencies broken by the automatic PR #103814.
Upstream paperspace has worked to rewrite its SDK which involves an update of the complete stack. The dangerous this here is this update includes
wheel
andnumpy
(even though for this one, it is a revision update).If you want to run nixpkgs-review, prepare for a big build I guess, I compiled the packages inside this PR only.
This will not compile before PR #103814 is merged.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)