Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

augustus: 1.4.1a -> 2.0.1 #103826

Merged
merged 1 commit into from Dec 25, 2020
Merged

augustus: 1.4.1a -> 2.0.1 #103826

merged 1 commit into from Dec 25, 2020

Conversation

Thra11
Copy link
Member

@Thra11 Thra11 commented Nov 14, 2020

Motivation for this change

Version update.

Almost certainly broken on darwin in the same way as #102263 (needs a program called sips to do something icon related). Not a new failure. Would be nice to fix it if possible, but could be a separate PR.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-in-distress/3604/38

@Thra11 Thra11 changed the title augustus: 1.4.1a -> 2.0.0 augustus: 1.4.1a -> 2.0.1 Nov 16, 2020
@SuperSandro2000
Copy link
Member

Fails to build on darwin:

libtool: link: clang++ -dynamiclib -Wl,-undefined -Wl,dynamic_lookup -o .libs/libmodplug.1.dylib  .libs/sndmix.o .libs/sndfile.o .libs/snd_fx.o .libs/snd_flt.o .libs/snd_dsp.o .libs/fastmix.o .libs/mmcmp.o .libs/load_xm.o .libs/load_wav.o .libs/load_umx.o .libs/load_ult.o .libs/load_stm.o .libs/load_s3m.o .libs/load_ptm.o .libs/load_okt.o .libs/load_mtm.o .libs/load_mod.o .libs/load_med.o .libs/load_mdl.o .libs/load_it.o .libs/load_far.o .libs/load_dsm.o .libs/load_dmf.o .libs/load_dbm.o .libs/load_ams.o .libs/load_amf.o .libs/load_669.o .libs/load_j2b.o .libs/load_mt2.o .libs/load_psm.o .libs/load_abc.o .libs/load_mid.o .libs/load_pat.o .libs/modplug.o   -lm  -g -O2 -mmacosx-version-min=10.5 -mmacosx-version-min=10.5   -install_name  /nix/store/v8hkzrplvwcikdidk761a04by98wjs3j-libmodplug-0.8.9.0/lib/libmodplug.1.dylib -compatibility_version 2 -current_version 2.0 -Wl,-single_module
0  0x108989a51  __assert_rtn + 129
1  0x108b62444  ld::passes::stubs::x86_64::classic::LazyPointerAtom::LazyPointerAtom(ld::passes::stubs::Pass&, ld::Atom const&, bool, bool) + 420
2  0x108b5fc6a  ld::passes::stubs::Pass::makeStub(ld::Atom const&, bool) + 2762
3  0x108b60c5f  ld::passes::stubs::Pass::process(ld::Internal&) + 2511
4  0x108b612c0  ld::passes::stubs::doPass(Options const&, ld::Internal&) + 128
5  0x10898aff4  main + 1860
6  0x7fff679f4cc9  start + 1
A linker snapshot was created at:
        /tmp/libmodplug.1.dylib-2020-10-23-221112.ld-snapshot
ld: Assertion failed: (targetAtom != NULL), function Fixup, file ../../../../ld64/src/ld/ld.hpp, line 776.
clang-7: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [Makefile:492: libmodplug.la] Error 1
make[2]: Leaving directory '/private/tmp/nix-build-libmodplug-0.8.9.0.drv-0/libmodplug-0.8.9.0/src'
make[1]: *** [Makefile:407: all] Error 2
make[1]: Leaving directory '/private/tmp/nix-build-libmodplug-0.8.9.0.drv-0/libmodplug-0.8.9.0/src'
make: *** [Makefile:444: all-recursive] Error 1
builder for '/nix/store/280lam50ipgqgs87habx33cwggjr1alp-libmodplug-0.8.9.0.drv' failed with exit code 2
cannot build derivation '/nix/store/f4j6b25h5m1hv7nkln6hd20dij9vl1xp-SDL2_mixer-2.0.4.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/80k3jh0caqqdnxak4ghjl0rjzc9q88z9-augustus-2.0.1.drv': 1 dependencies couldn't be built
error: build of '/nix/store/80k3jh0caqqdnxak4ghjl0rjzc9q88z9-augustus-2.0.1.drv' failed

@Thra11
Copy link
Member Author

Thra11 commented Nov 23, 2020

Thanks for the heads-up. Looking at hydra, appears that libmodplug failure on darwin was fixed a couple of days ago, so I've rebased this pull request.

@Thra11
Copy link
Member Author

Thra11 commented Nov 26, 2020

(I've also marked this as broken on darwin as I believe it suffers from the same missing sips issue as julius)

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 103826 run on x86_64-linux 1

1 package built:
  • augustus

Mark as broken on darwin.
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 103826 run on x86_64-linux 1

1 package built:
  • augustus

@SuperSandro2000 SuperSandro2000 merged commit 8dbd527 into NixOS:master Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants