Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onionshare: 2.2 -> 2.3.1 #103844

Merged
merged 3 commits into from Feb 24, 2021
Merged

onionshare: 2.2 -> 2.3.1 #103844

merged 3 commits into from Feb 24, 2021

Conversation

bbjubjub2494
Copy link
Member

@bbjubjub2494 bbjubjub2494 commented Nov 14, 2020 •
edited

Motivation for this change

Upstream release. Changelog

The structure of the nix expression changed quite a bit, but that's because the structure of upstream did too, and for the better. They introduced Flatpak and Snap as their main method of distribution. Since those are declarative, this makes our job easier.

Things done
  • Wait for final release
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Is this read to be undraftet?

@bbjubjub2494
Copy link
Member Author

Is this read to be undraftet?

I plan to undraft it when the final release drops.

@SuperSandro2000
Copy link
Member

@lourkeur ping

@bbjubjub2494
Copy link
Member Author

@lourkeur ping

2.3 is still not out. Thank you for your interest.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 103844 run on x86_64-linux 1

2 packages built:
  • onionshare
  • onionshare-gui

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

onionshare-gui:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.

@bbjubjub2494 bbjubjub2494 marked this pull request as ready for review February 22, 2021 08:15
@bbjubjub2494
Copy link
Member Author

https://github.com/micahflee/onionshare/releases/tag/v2.3.1

@bbjubjub2494 bbjubjub2494 marked this pull request as draft February 22, 2021 23:06
@bbjubjub2494 bbjubjub2494 changed the title onionshare: 2.2 -> 2.3 onionshare: 2.2 -> 2.3.1 Feb 23, 2021
@bbjubjub2494 bbjubjub2494 marked this pull request as ready for review February 23, 2021 07:49
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 103844 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • onionshare-gui
1 package failed to build and already failed to build on hydra master:

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

onionshare:

Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/applications/networking/onionshare/default.nix:65:7:

   |
65 |       (substituteAll {
   |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/applications/networking/onionshare/default.nix:103:7:

    |
103 |       (substituteAll {
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md
Unused argument: stdenv.
Near pkgs/applications/networking/onionshare/default.nix:4:3:

  |
4 |   stdenv,
  |   ^

Unused argument: pysocks.
Near pkgs/applications/networking/onionshare/default.nix:16:3:

   |
16 |   pysocks,
   |   ^

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 103844 run on x86_64-linux 1

2 packages failed to build and are new build failures:

@bbjubjub2494
Copy link
Member Author

@SuperSandro2000 fixed the hammering lints

@Mic92 Mic92 merged commit 7ce33fa into NixOS:master Feb 24, 2021
@bbjubjub2494 bbjubjub2494 deleted the onionshare-2.3 branch February 24, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bbjubjub2494 @SuperSandro2000 @Mic92