Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fix for compatibility issue with python3Packages.colorama: #104421
Related PR: #104453
Things done
I override the botocore to match with awscli required version.
(not sure if i should have instead bumped the standard botocore)
And also postPatch substitute colorama requirement.
@flokli asked me if I could make this pr in #104421
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
I did, and got this fault,
But that shouldnt be related to this change.
./result/bin/
)nix path-info -S
before and after)This works when i run it from my own nixrepo here:
afreakk/mynixrepo@5feeb9f