Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

awscli: 1.18.150 -> 1.18.183 #104588

Closed
wants to merge 1 commit into from
Closed

awscli: 1.18.150 -> 1.18.183 #104588

wants to merge 1 commit into from

Conversation

afreakk
Copy link
Contributor

@afreakk afreakk commented Nov 22, 2020

Motivation for this change

Fix for compatibility issue with python3Packages.colorama: #104421
Related PR: #104453

Things done

I override the botocore to match with awscli required version.
(not sure if i should have instead bumped the standard botocore)
And also postPatch substitute colorama requirement.

@flokli asked me if I could make this pr in #104421

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"

I did, and got this fault,

error: build of '/nix/store/7xwcd09hb8hn1ffjqx4xws97h5zjbhrs-env.drv' failed
1 package failed to build:
gitAndTools.git-remote-codecommit

But that shouldnt be related to this change.

  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This works when i run it from my own nixrepo here:
afreakk/mynixrepo@5feeb9f

@flokli
Copy link
Contributor

flokli commented Nov 22, 2020

Thanks @afreakk for the PR!

git-remote-codecommit is checked, because it's using awscli as a build input, so changes after this commit.

It fails to build, as two different versions of botocore are pulled in - one through awscli, one as a direct dependency:

why-depends
why-depends2

We have some tooling checking no two versions of python packages are propagated as dependencies.

Our tooling currently simply propagates python dependencies, and doesn't stop propagating them on pythonApplication types of packages (where their binary is called, so it's another python process), or, like here, packages that are even only used in checkInputs.

This could be workarounded by ensuring gitAndTools.git-remote-codecommit is built with the same botocore version that awscli is built with (probably by exposing it there as a passthru, and reusing that here - but in the longer term, we might want to make pkgs/development/interpreters/python/catch_conflicts/catch_conflicts.py a bit smarter ;-)

@johbo, @FRidh, what do you think?

@SuperSandro2000
Copy link
Member

@afreakk please resolve the merge conflict.

@afreakk
Copy link
Contributor Author

afreakk commented Jan 18, 2021

@SuperSandro2000 newest version of awscli in master matches the default botocore. and does not have any issues with colorama.
So I think I can close this PR.

@afreakk afreakk closed this Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants